-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Use Swift Package Index for how to install and documentation #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kou, it is needed as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that we need these configurations to generate documentation on Swift Package Index and we can't refer generated documentation after our next release?
If so, could you split the "adding support for documentation generation on Swift Package Index" changes and the "update README" changes to separated PRs?
We'll work on the former BEFORE we release a new version and work on the later changes AFTER we release a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kou, it is needed as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation
## Install | ||
|
||
TODO: We should update this after we register this package to Swift Package Index. | ||
[](https://swiftpackageindex.com/apache/arrow-swift) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this badge URL is 404: https://swiftpackageindex.com/apache/arrow-swift/badge.swift
Could you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation
TODO: We should update this after we register this package to Swift Package Index. | ||
[](https://swiftpackageindex.com/apache/arrow-swift) | ||
|
||
You can add Apache Arrow Swift to your project using Swift Package Manager. For complete installation instructions and version selection, see the [Swift Package Index page](https://swiftpackageindex.com/apache/arrow-swift/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that https://swiftpackageindex.com/apache/arrow-swift/ doesn't include "complete installation instructions". Should we write them by ourselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation
## Getting Started | ||
|
||
TODO: We should refer auto generated documentation on Swift Package Index after we register this package to Swift Package Index. | ||
You can browse API documentation and usage examples at our [Swift Package Index documentation page](https://swiftpackageindex.com/apache/arrow-swift/documentation). Once added, import Arrow in your code and get started! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that https://swiftpackageindex.com/apache/arrow-swift/documentation doesn't exist. Could you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert needless changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove these
What's Changed
We can refer Swift Package Index because we've released a new version and registered to Swift Package Index.
Closes #86.